Summary

Fixes #2259

Changes

• Added PHP version for Ubuntu 22.04 (and 16.04) to the $php_version mapping in params.pp.
• In mod/php.pp added conditions for Red Hat family that has a specific behavior with PHP 8.x modules name convention.

Tests

Tested with the following Puppet code:

class { 'apache':
  mpm_module => 'prefork',
}
class { 'apache::mod::php': }

To validate that PHP works:

# Don't do this in production servers!
echo "<?php phpinfo(); ?>" > /var/www/html/phpinfo.php

Then open http://<sandbox_ip>/phpinfo.php

Works on:

• Ubuntu 16.04
• Ubuntu 18.04
• Ubuntu 20.04
• Ubuntu 22.04
• CentOS 7
• CentOS 8
• Debian 11

I could not test SLES because it's not free. I tried openSuse Leap 15.4 but the module does not seems to work for other reasons.

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

apache::mod::php is a class

Breaking changes to this file WILL impact these 49 modules (exact match):

• Firebladee-moodle
• lightoze-bacula
• binford2k-drupal
• monkygames-beansbooks
• martialblog-limesurvey
• nubevps-wordpress
• sasireddyfm-myapp
• pkumarnath-myapp
• thexa4-secrets_server
• vinish098-myapp
• snaragoni-myapp
• ranjithsimple-myapp
• puppetlabs-wordpress_app
• premkumarp-myapp
• kumarmks6-myapp
• ganeshselva95-myapp
• tejoyasha-myapp
• pwaghray-myapp
• jgazeley-speedtest
• brucem-ezpublish
• martasd-mediawiki
• stesie-gluon
• fancyolaya-dokuwiki
• zyronix-dokuwiki
• jgazeley-nagios
• southernhill-phpldapadmin
• hexmode-mediawiki
• sgnl05-racktables
• shoekstra-owncloud
• gajdaw-phpmyadmin
• benjaminrobertson-observium
• wyrie-nagiosql
• cirrax-roundcube
• alexggolovin-lamp
• cirrax-autoconfigmail
• rendhalver-icinga
• cirrax-postfixadmin
• datacentred-nfsen
• jlondon-phpmyadmin
• aimonb-nexusis_mediawiki
• devika-myapp
• gajdaw-symfony
• treydock-xdmod
• SchnWalter-happydev
• geoffwilliams-r_profile
• abstractit-icinga
• glarizza-profiles
• puppetlabs-awsdemo_profiles
• pieterdp-hx_apache

Breaking changes to this file MAY impact these 36 modules (near match):

• dbsrinivasulu-mediawiki
• knowshan-phppgadmin
• suvarnagodri-mediawiki
• shantanumalik-mediawiki
• kiranhosamani-mediawiki
• nitish741-mediawiki
• manish1984-mediawiki
• vinaycharles-mediawiki
• sunilh-mediawiki
• niksv-mediawiki
• narenv-mediawiki
• byjupv-mediakwiki
• pbhutani-mediawiki
• funaccount-mediawiki
• raviforge-mediawiki
• abhaysoni-mediawiki
• webserve-mediawiki
• hegdec-mediawiki
• gururaj-mediawiki
• parthitraining-mediawiki
• preethi-mediawiki
• gsachar1-mediawiki
• jaysingh-mediawiki
• mithilas-mediawiki
• pia-mediawiki
• 214310-mediawiki
• hemantgangwar-mediawiki
• prakash007-mediawiki
• anthomas-mediawiki
• ravishankar1jan-mediawiki
• samuelson-dockeragent
• eupathdb-ebrc_httpd_setup
• puppetfinland-librenms
• pltraining-dockeragent
• esakazmi-mediawiki
• rspiak-racktables

apache::params is a class

Breaking changes to this file WILL impact these 7 modules (exact match):

• xdrum-puppet
• brucem-ezpublish
• desalvo-bacula
• jlondon-phpmyadmin
• openstack-panko
• osc-openondemand
• openstack-keystone

Breaking changes to this file MAY impact these 4 modules (near match):

• camptocamp-catalog_diff
• puppet-catalog_diff
• openstack-tripleo
• willdurand-bazinga

This module is declared in 174 of 579 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Relevant previous effort: https://github.com/puppetlabs/puppetlabs-apache/pull/2163

Tested with the following Puppet code:

class { 'apache':
  mpm_module => 'prefork',
}
class { 'apache::mod::php': }

To validate that PHP works:

# Don't do this in production servers!
echo "<?php phpinfo(); ?>" > /var/www/html/phpinfo.php

Then open http://<sandbox_ip>/phpinfo.php

This would be a great acceptance test. In fact, there already is https://github.com/puppetlabs/puppetlabs-apache/blob/main/spec/acceptance/mod_php_spec.rb but that doesn't run anything like curl to see if it actually renders.

@xchotard-talentsoft If you could add Ubuntu 22.04 to the metadata that should activate the tests against it to double-check this change. From my own pr added Certification for the OS it look's like yours should fix all outstanding issues.

@xchotard-talentsoft If you could add Ubuntu 22.04 to the metadata that should activate the tests against it to double-check this change. From my own pr added Certification for the OS it look's like yours should fix all outstanding issues.

Done, but I haven't tested any of the other apache modules.

@xchotard-talentsoft Hey, as part of my scheduled work to get all our our modules to support Ubuntu 22.04 have finalized the work started by you and added it to the pdksync PR shown here and was hoping you could give it a quick review.

Hope there's no offense taken, just need to get this done so I can move onto my next task. Pinging @ekohl as well

@xchotard-talentsoft Closing this as the need has bee filled by another PR. If there is anything else that you wanted to get in with it please re-open and comment.

Thank you for all your work