puppetlabs-ruby icon indicating copy to clipboard operation
puppetlabs-ruby copied to clipboard

use ensure_package from stdlib instead of raw package type

Open scarybot opened this issue 8 years ago • 3 comments

This module wasn't working for me due to duplicate definitions, because I'm using other modules from the forge which require ruby / rubygems packages. They're using ensure_packages() to achieve this. As you're depending on stdlib anyway, I couldn't see any harm in tweaking this module to do the same, and it's playing nicely now alongside the other modules in my environment. Let me know if this is a stupid idea!

scarybot avatar May 30 '17 11:05 scarybot

Hi @scarybot, thanks for the PR. Can you please rebase this against master? Please also check the used email address in the commit, it isn't associated with your github account.

bastelfreak avatar Jun 23 '17 08:06 bastelfreak

Hi - I've just fixed some conflicts, changed the email address and rebased.

scarybot avatar Jul 20 '17 15:07 scarybot

Hi @scarybot, the email address in the new commit isn't correct :)

bastelfreak avatar Jul 20 '17 15:07 bastelfreak