puppeteer icon indicating copy to clipboard operation
puppeteer copied to clipboard

Smoke tests fixed for local running

Open Riyazul555 opened this issue 1 year ago • 2 comments

What kind of change does this PR introduce?

Error Handling:

Wrapped the main logic in an async function (runSmokeTests) and added a .catch block to handle any uncaught exceptions. This ensures any errors are logged, and the process exits with a failure code. Initialization:

Ensured that the script initializes and installs dependencies correctly in the CI environment. Await in Loop:

Used a regular for loop instead of for await for iterating through runnerGroup to keep consistency and avoid issues.

Did you add tests for your changes?

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information Closes Issue #12619

Riyazul555 avatar Jun 30 '24 06:06 Riyazul555

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jun 30 '24 06:06 google-cla[bot]

@OrKoN please checkout This PR if any changes are required do tell me Thanks

Riyazul555 avatar Jun 30 '24 06:06 Riyazul555

@Riyazul555 please sign the CLA so that the CLA check passes

OrKoN avatar Jul 01 '24 06:07 OrKoN

Hey @OrKoN can you please tell me how to sign the CLA pass ? Thanks

Riyazul555 avatar Jul 01 '24 06:07 Riyazul555

@Riyazul555 you can follow the instructions from the check posted above https://github.com/puppeteer/puppeteer/pull/12687/checks?check_run_id=26852656282

OrKoN avatar Jul 01 '24 06:07 OrKoN

I rescanned the CLA @OrKoN Please see it

Riyazul555 avatar Jul 01 '24 06:07 Riyazul555

I think it still not detected

OrKoN avatar Jul 01 '24 06:07 OrKoN

What to do next @OrKoN ?

Riyazul555 avatar Jul 01 '24 06:07 Riyazul555

@OrKoN any updates ?

Riyazul555 avatar Jul 01 '24 07:07 Riyazul555

It seems that your GitHub account is not associated with the email you sign. And the PR was uploaded with the one you signed the CLA with. Please see https://github.com/puppeteer/puppeteer/pull/12687/checks?check_run_id=26875817171 Also commenting one time is enough, refrain from spamming multiple messages please.

Lightning00Blade avatar Jul 01 '24 07:07 Lightning00Blade

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

Supersede by #12711.

Lightning00Blade avatar Jul 05 '24 13:07 Lightning00Blade