php-subscriber icon indicating copy to clipboard operation
php-subscriber copied to clipboard

No setters for protected arguments

Open danmichaelo opened this issue 8 years ago • 1 comments

Seems to be no way to set lease_seconds, verify etc.??

danmichaelo avatar May 29 '17 16:05 danmichaelo

Suggestion: Add an $options array to the constructor and extract the optional values from there:

public function __construct($hub_url, $callback_url, $credentials = false, $options = [])
    $this->lease_seconds = isset($options['lease_seconds']) ? $options['lease_seconds'] : null;
    ...

danmichaelo avatar May 29 '17 18:05 danmichaelo