plots2

plots2 copied to clipboard

Add new vocabulary to .yml file to support more languages.

Fixes #11117

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• [x] PR is descriptively titled 📑 and links the original issue above 🔗
• [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• [x] code is in uniquely-named feature branch and has no merge conflicts 📁
• [ ] screenshots/GIFs are attached 📎 in case of UI updation
• [x] ask @publiclab/reviewers for help, in a comment below

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/6394925682/artifacts/232619971

Thank you @cesswairimu I'll slowly continue on it 💯

please let me know if/when its ready to be merged :). Thanks

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/6502361825/artifacts/241526027

Code Climate has analyzed commit b2ff070c and detected 0 issues on this pull request.

View more on Code Climate.

It took a lot of scrolling but here is the error!

https://github.com/publiclab/plots2/runs/6437218263?check_suite_focus=true#step:9:96

ERROR QuestionTest#test_posting_a_question (94.57s)
Minitest::UnexpectedError:         Capybara::ElementNotFound: Unable to find visible css ".alert-success"
            test/system/post_question_test.rb:66:in `block in <class:QuestionTest>'

I think this one is an intermittent one unrelated to your code which we can get past by restarting the test!

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/6508880717/artifacts/242477196

Looks like it passed!! Is it ready for a final review?

@jywarren sorry, I missed your message. I will add some more to be able to 'launch' new language on the website. Size +/- the French translation. Thank you 🙂

Hi :smile:, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add in-progress label :tada: . Otherwise, it will be closed if no further activity occurs in 10 days -- but you can always re-open it if you like! :100: Thank you for your contributions! :raised_hands: :balloon:.