plots2

plots2 copied to clipboard

Made changes in the wiki.css file to resolve the issue of the target element hiding behind the fixed header. I changed the css code of the hidden anchor(which was the main target of the link icon), by setting the values of padding-top and margin-top css properties, to offset it according to the height of the header.

Fixes #10744

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• [x] PR is descriptively titled 📑 and links the original issue above 🔗
• [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• [x] code is in uniquely-named feature branch and has no merge conflicts 📁
• [x] screenshots/GIFs are attached 📎 in case of UI updation
• [x] ask @publiclab/reviewers for help, in a comment below

https://user-images.githubusercontent.com/84193017/158222268-8932e3f2-8c2e-4351-825e-842418c52907.mp4

Code Climate has analyzed commit 40299497 and detected 0 issues on this pull request.

View more on Code Climate.

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/5651399825/artifacts/184916654

Looks good to me! Thanks @Ash-KODES

Pleasure is always mine:)got to learn many things

Hi, this looks super. I wonder if one of the issues here was that the "ribbon" across the top (in lavender color) is pushing the navbar down. If that's the case, then when the ribbon is removed, these anchors will be a little too low, right?

So I have 2 questions:

1. do you think my guess is true about the ribbon (shall we try removing it for now to test?)
2. even if anchors are too low, that's much better than too high, right? I mean, maybe this solution is good even so! What do you think?

I saved the content of the ribbon (which can be modified by admins) so you can see the code. It does include some CSS:

https://gist.github.com/jywarren/c5b4ae1e1a5dc4e6518b179dbba8dad7

Hi :smile:, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add in-progress label :tada: . Otherwise, it will be closed if no further activity occurs in 10 days -- but you can always re-open it if you like! :100: Thank you for your contributions! :raised_hands: :balloon:.