image-sequencer icon indicating copy to clipboard operation
image-sequencer copied to clipboard

Clear Input Field After Selecting a Module/Step

Open vivek-30 opened this issue 4 years ago • 10 comments

Please describe the problem (or idea)

What happened just before the problem occurred? Or what problem could this idea solve?

The Step remains Intact in the input field Even after its selection.

observe it here -

https://user-images.githubusercontent.com/75980147/109331037-590c6c00-7882-11eb-826c-69e000501685.mov

What did you expect to see that you didn't?

After Selecting a Step/Module the input field must be Cleared out, so that a user don't have to manually erase it to choose another step.

Please show us where to look

https://beta.sequencer.publiclab.org/

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

vivek-30 avatar Feb 26 '21 17:02 vivek-30

Thanks for opening your first issue here! This space is protected by our Code of Conduct - and we're here to help. Please follow the issue template to help us help you 👍🎉😄 If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too! Don't forget to join our PublicLab Gitter channel and our ImageSequencer Gitter Channel for some brainstorming discussions.

welcome[bot] avatar Feb 26 '21 17:02 welcome[bot]

@HarshKhandeparkar what do you think of this ?

vivek-30 avatar Feb 27 '21 04:02 vivek-30

A small but nice change.

harshkhandeparkar avatar Feb 27 '21 04:02 harshkhandeparkar

@harshkhandeparkar can I work on this?

KarishmaVanwari avatar Feb 10 '22 13:02 KarishmaVanwari

@harshkhandeparkar can I work on this?

Go ahead!

harshkhandeparkar avatar Feb 16 '22 18:02 harshkhandeparkar

Hi, I would like to fix this issue. Do you still want this fixed?

k99sharma avatar Oct 01 '22 12:10 k99sharma

Hi, I would like to fix this issue. Do you still want this fixed?

Sure!

harshkhandeparkar avatar Oct 01 '22 12:10 harshkhandeparkar

Hey, I tried looking for the bug. I found this in the index.html file in examples/ folder. index.html

index html - image-sequencer - Gitpod Code

I looked in the demo.js file which is calling addStepsUI handler function to add options in here. We are seeing the last choosed option because we added <options> in <select> manually using the script.

This handler is present in this file defaultHTMLSequencerUi. But I am not able to figure out how is this file getting generated.

k99sharma avatar Oct 01 '22 17:10 k99sharma

It's not a generated file, it is the source.

harshkhandeparkar avatar Oct 01 '22 18:10 harshkhandeparkar

You can run npm start to test your changes in the browser.

harshkhandeparkar avatar Oct 01 '22 18:10 harshkhandeparkar