image-sequencer icon indicating copy to clipboard operation
image-sequencer copied to clipboard

Added Dark Mode For ImageSequencer

Open vivek-30 opened this issue 4 years ago • 13 comments

Fixes #851. Now there will be a cool dark-mode for the image-sequencer.

vivek-30 avatar Feb 26 '21 15:02 vivek-30

gitpod-io[bot] avatar Feb 26 '21 15:02 gitpod-io[bot]

This is the Working Demo -

https://user-images.githubusercontent.com/75980147/109323113-1c884280-7879-11eb-8e5e-072f665f42f1.mov

vivek-30 avatar Feb 26 '21 15:02 vivek-30

@jywarren , @HarshKhandeparkar could you please review this 😊 .

vivek-30 avatar Feb 26 '21 16:02 vivek-30

This is the Working Demo -

Screen.Recording.2021-02-26.ast.9.16.42.PM.mov

If that is the latest video then it still has many light elements...

harshkhandeparkar avatar Feb 26 '21 18:02 harshkhandeparkar

This is the Working Demo - Screen.Recording.2021-02-26.ast.9.16.42.PM.mov

If that is the latest video then it still has many light elements...

@HarshKhandeparkar are you talking about panel-body's ?

vivek-30 avatar Feb 26 '21 18:02 vivek-30

are you talking about panel-body's ?

Those and the buttons.

harshkhandeparkar avatar Feb 26 '21 18:02 harshkhandeparkar

i have made the text white to highlight them in dark-mode and talking about the panels i don't fell like to change them as they look very decent with this theme.

vivek-30 avatar Feb 26 '21 18:02 vivek-30

i have made the text white to highlight them in dark-mode and talking about the panels i don't fell like to change them as they look very decent with this theme.

I feel like grey will look better. This contrast is too high. What do you think?

harshkhandeparkar avatar Feb 26 '21 18:02 harshkhandeparkar

i have made the text white to highlight them in dark-mode and talking about the panels i don't fell like to change them as they look very decent with this theme.

I feel like grey will look better. This contrast is too high. What do you think?

ok i will give it a try. just a final confirmation grey color for panels and for button which color are you suggesting btw?

vivek-30 avatar Feb 26 '21 18:02 vivek-30

ok i will give it a try. just a final confirmation grey color for panels and for button which color are you suggesting btw?

https://material.io/design/color/dark-theme.html maybe something like this

harshkhandeparkar avatar Feb 26 '21 18:02 harshkhandeparkar

Hi all, thanks for the discussion! I'm wondering if there are some standard ways to implement this for Bootstrap that could involve just a single class being added, in addition to a standard CSS file?

https://duckduckgo.com/?q=bootstrap+4+dark+mode+css&atb=v121-6&ia=software

jywarren avatar Feb 26 '21 21:02 jywarren

@jywarren, @HarshKhandeparkar is it ok if i will solve this further after few days later . As i will be busy for next 3 weeks due to my college exams. Also this feature will require significant amount of time to complete bcoz its not only about adding bootstrap classes. we have to control the dynamic behaviour of the sequencer too.

look -

https://user-images.githubusercontent.com/75980147/109392516-70ab2980-7942-11eb-9c68-1a431879df9e.mov

i have tried to change the color for panels but it only changes for current one and does not apply when we add a new step

vivek-30 avatar Feb 27 '21 15:02 vivek-30

BTW @jywarren #1819 is ready to for a review ,as i did all the requested changes. lastly Thank you sir for your time😊

vivek-30 avatar Feb 27 '21 16:02 vivek-30