image-sequencer
image-sequencer copied to clipboard
image docs links fixed
Fixes #1525
- [ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with
npm run test-all - [x] code is in a uniquely-named feature branch and has no merge conflicts
- [x] PR is descriptively titled
- [x] ask
@publiclab/is-reviewersfor help, in a comment below - [x] Insert-step functionality is working correct as expected.
We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!
If tests do fail, click on the red X to learn why by reading the logs.
Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part Thanks!
Thanks for opening this pull request! There may be some errors, but don't worry! We're here to help! 👍🎉😄
Codecov Report
Merging #1717 into main will decrease coverage by
1.21%. The diff coverage is47.16%.
@@ Coverage Diff @@
## main #1717 +/- ##
==========================================
- Coverage 66.67% 65.46% -1.22%
==========================================
Files 130 133 +3
Lines 2686 2748 +62
Branches 433 440 +7
==========================================
+ Hits 1791 1799 +8
- Misses 895 949 +54
| Impacted Files | Coverage Δ | |
|---|---|---|
| examples/lib/defaultHtmlStepUi.js | 11.35% <0.00%> (ø) |
|
| src/Modules.js | 100.00% <ø> (ø) |
|
| src/modules/EdgeDetect/Module.js | 100.00% <ø> (ø) |
|
| src/modules/WebglDistort/Module.js | 2.29% <0.00%> (ø) |
|
| src/modules/ColorHalftone/Module.js | 3.63% <3.63%> (ø) |
|
| src/modules/Overlay/Module.js | 93.18% <94.11%> (-1.69%) |
:arrow_down: |
| src/modules/ColorHalftone/index.js | 100.00% <100.00%> (ø) |
|
| src/modules/Colorbar/Module.js | 100.00% <100.00%> (ø) |
|
| src/modules/Crop/Module.js | 88.88% <100.00%> (ø) |
|
| src/modules/EdgeDetect/EdgeUtils.js | 86.81% <100.00%> (-0.15%) |
:arrow_down: |
| ... and 5 more |
please review my PR
@blurry-x-face is my PR ready to merge?
UI tests need update, try running tests locally to track down which test is failing
@blurry-x-face can you please label it as hacktoberfest-accepted, :)
/rebase