image-sequencer
image-sequencer copied to clipboard
github action to publish demo at sequencer.publiclab.org
Try setting up github action to publish demo, following @harshithpabbati's work in https://github.com/harshithpabbati/image-sequencer/blob/main/.github/workflows/upstream.yml
Re: https://github.com/publiclab/image-sequencer/issues/1692
How does this look? So to trigger it we publish a release on GitHub. We could alternatively try to trigger it on when the version number is incremented in the main branch?
Codecov Report
Merging #1703 (6052e78) into main (853e719) will decrease coverage by
1.79%. The diff coverage is46.48%.
:exclamation: Current head 6052e78 differs from pull request most recent head 782bc50. Consider uploading reports for the commit 782bc50 to get more accurate results
@@ Coverage Diff @@
## main #1703 +/- ##
==========================================
- Coverage 66.67% 64.88% -1.80%
==========================================
Files 130 135 +5
Lines 2686 2828 +142
Branches 433 458 +25
==========================================
+ Hits 1791 1835 +44
- Misses 895 993 +98
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/Modules.js | 100.00% <ø> (ø) |
|
| src/modules/EdgeDetect/Module.js | 100.00% <ø> (ø) |
|
| src/modules/WebglDistort/Module.js | 2.29% <0.00%> (ø) |
|
| src/modules/ColorHalftone/Module.js | 3.63% <3.63%> (ø) |
|
| src/modules/Shadow/Module.js | 44.30% <44.30%> (ø) |
|
| src/modules/Overlay/Module.js | 93.18% <94.11%> (-1.69%) |
:arrow_down: |
| src/modules/ColorHalftone/index.js | 100.00% <100.00%> (ø) |
|
| src/modules/Colorbar/Module.js | 100.00% <100.00%> (ø) |
|
| src/modules/Crop/Module.js | 88.88% <100.00%> (ø) |
|
| src/modules/EdgeDetect/EdgeUtils.js | 86.81% <100.00%> (-0.15%) |
:arrow_down: |
| ... and 8 more |
Noting this really cool script by @sagarpreet-chadha that generates a release -- https://github.com/publiclab/plots2/releases/tag/v4.0
Quoting myself from the chatroom --
@sagarpreet-chadha i love it. https://github.com/publiclab/plots2/releases/tag/v4.0 -- i'm really excited for it. I wonder if it could be a GitHub Action -- see how i'm trying to build one here - publiclab/image-sequencer#1703 -- like, could it pull the "release author" from an issue or something? Or a PR? I dunno. Where is the script kept? Would we run this like once per week maybe? What if it were, like, built out of the weekly check-in?
anyways all just ideas... this is awesome as-is of course! Thanks!
OK! So, shall we refactor this to use the Bash script from https://github.com/publiclab/image-sequencer/pull/1739?
yes!
@publiclab/is-maintainers Let's focus on this one next.
I pushed something but I don't know if it is correct. @harshithpabbati ?
oh great, that's a good idea! https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow
On Thu, Mar 18, 2021 at 8:32 AM Barun Acharya @.***> wrote:
@.**** commented on this pull request.
In .github/workflows/republish.yml https://github.com/publiclab/image-sequencer/pull/1703#discussion_r596823852 :
@@ -0,0 +1,16 @@ +name: Publish sequencer.publiclab.org demo
+on:
We should also add manual triggers. We can use the workflow_dispatch event.
Ref https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch/
https://docs.github.com/en/actions/reference/events-that-trigger-workflows#workflow_dispatch
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/pull/1703#pullrequestreview-615326585, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6J2R7AFXBCPXWMY4WPLTEHXFRANCNFSM4PT6OWXQ .