image-sequencer icon indicating copy to clipboard operation
image-sequencer copied to clipboard

Added Face detection Module

Open ataata107 opened this issue 5 years ago • 4 comments

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks! ezgif com-video-to-gif

This Module doesn't make the use of opencv as discussed

  • [ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
  • [X] code is in uniquely-named feature branch and has no merge conflicts
  • [X] PR is descriptively titled
  • [X] ask @publiclab/is-reviewers for help, in a comment below
  • [X] Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part Thanks!

ataata107 avatar Jan 29 '20 14:01 ataata107

@publiclab/is-reviewers

ataata107 avatar Jan 29 '20 14:01 ataata107

@ataata107 why are the tests failing?

rishabhshuklax avatar Jan 30 '20 15:01 rishabhshuklax

gitpod-io[bot] avatar Jul 07 '20 16:07 gitpod-io[bot]

Codecov Report

Merging #1597 into main will increase coverage by 10.09%. The diff coverage is 63.17%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1597       +/-   ##
===========================================
+ Coverage   55.11%   65.21%   +10.09%     
===========================================
  Files         117      134       +17     
  Lines        2344     2757      +413     
  Branches      360      438       +78     
===========================================
+ Hits         1292     1798      +506     
+ Misses       1052      959       -93     
Impacted Files Coverage Δ
examples/lib/scopeQuery.js 18.51% <ø> (ø)
src/Modules.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/ui/SetInputStep.js 12.90% <0.00%> (-1.39%) :arrow_down:
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
examples/lib/defaultHtmlStepUi.js 11.35% <4.08%> (-0.85%) :arrow_down:
examples/lib/intermediateHtmlStepUi.js 11.11% <5.55%> (+0.94%) :arrow_up:
examples/lib/insertPreview.js 13.15% <20.00%> (-0.36%) :arrow_down:
src/util/getImageDimensions.js 20.00% <20.00%> (ø)
src/util/isGif.js 20.00% <20.00%> (ø)
... and 104 more

codecov[bot] avatar Jul 07 '20 17:07 codecov[bot]