image-sequencer icon indicating copy to clipboard operation
image-sequencer copied to clipboard

Fix NDVI values getting overwritten by rgba values when hovered over image

Open rishabhshuklax opened this issue 5 years ago • 4 comments

Fixes #1594

ndvi

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
  • [x] code is in uniquely-named feature branch and has no merge conflicts
  • [x] PR is descriptively titled
  • [x] ask @publiclab/is-reviewers for help, in a comment below
  • [x] Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part Thanks!

rishabhshuklax avatar Jan 29 '20 08:01 rishabhshuklax

Codecov Report

Merging #1595 into main will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1595   +/-   ##
=======================================
  Coverage   66.65%   66.65%           
=======================================
  Files         130      130           
  Lines        2687     2687           
  Branches      434      434           
=======================================
  Hits         1791     1791           
  Misses        896      896

codecov[bot] avatar Jan 29 '20 08:01 codecov[bot]

@publiclab/is-reviewers

rishabhshuklax avatar Jan 29 '20 09:01 rishabhshuklax

Ah, this is great. Are we able to add to the UI test for this module? Thank you!

jywarren avatar Jan 29 '20 15:01 jywarren

@jywarren I was trying to add the test for this but was not able to trigger the hover event for the image, do you have any idea how to procced further, Thanks!

rishabhshuklax avatar Jan 30 '20 15:01 rishabhshuklax