image-sequencer icon indicating copy to clipboard operation
image-sequencer copied to clipboard

Add easy to use interface for draw-rectangle

Open rishabhshuklax opened this issue 5 years ago • 6 comments

This PR adds easy to use interface for draw-rectangle

draw-rect

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
  • [x] code is in uniquely-named feature branch and has no merge conflicts
  • [x] PR is descriptively titled
  • [x] ask @publiclab/is-reviewers for help, in a comment below
  • [x] Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part Thanks!

rishabhshuklax avatar Jan 28 '20 21:01 rishabhshuklax

Codecov Report

Merging #1590 into main will increase coverage by 10.29%. The diff coverage is 64.08%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1590       +/-   ##
===========================================
+ Coverage   55.11%   65.41%   +10.29%     
===========================================
  Files         117      132       +15     
  Lines        2344     2747      +403     
  Branches      360      442       +82     
===========================================
+ Hits         1292     1797      +505     
+ Misses       1052      950      -102     
Impacted Files Coverage Δ
examples/lib/scopeQuery.js 18.51% <ø> (ø)
src/Modules.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/ui/SetInputStep.js 12.90% <0.00%> (-1.39%) :arrow_down:
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
examples/lib/defaultHtmlStepUi.js 11.35% <4.08%> (-0.85%) :arrow_down:
examples/lib/intermediateHtmlStepUi.js 11.11% <5.55%> (+0.94%) :arrow_up:
examples/lib/insertPreview.js 13.15% <20.00%> (-0.36%) :arrow_down:
src/util/getImageDimensions.js 20.00% <20.00%> (ø)
src/util/isGif.js 20.00% <20.00%> (ø)
... and 100 more

codecov[bot] avatar Jan 28 '20 21:01 codecov[bot]

@publiclab/is-reviewers @jywarren please review this

rishabhshuklax avatar Jan 28 '20 22:01 rishabhshuklax

gitpod-io[bot] avatar Jul 08 '20 05:07 gitpod-io[bot]

Confirmed this works in GitPod! I'll update but do you think you could add an instruction saying "please draw a rectangle by dragging" or something?

Screen Shot 2020-07-10 at 2 57 37 PM Screen Shot 2020-07-10 at 2 57 44 PM

jywarren avatar Jul 10 '20 18:07 jywarren

Hi @jywarren hope you're doing well, I've updated the PR to include the helper text, kindly review it again!

rishabhshuklax avatar Jul 12 '20 14:07 rishabhshuklax

Nice! Tested and confirmed in GitPod:

image

jywarren avatar Aug 04 '20 03:08 jywarren