image-sequencer
image-sequencer copied to clipboard
Show histogram values
Fixes #1457 (<=== Replace 0000 with the Issue Number)
So apparently extraManipulation was being called before than changePixel hence the changes were required

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
- [X] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with
npm test - [X] code is in uniquely-named feature branch and has no merge conflicts
- [X] PR is descriptively titled
- [X] ask
@publiclab/is-reviewersfor help, in a comment below - [X] Insert-step functionality is working correct as expected.
We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!
If tests do fail, click on the red X to learn why by reading the logs.
Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part Thanks!
Codecov Report
Merging #1458 into main will increase coverage by
10.29%. The diff coverage is64.11%.
@@ Coverage Diff @@
## main #1458 +/- ##
===========================================
+ Coverage 55.11% 65.41% +10.29%
===========================================
Files 117 132 +15
Lines 2344 2741 +397
Branches 360 438 +78
===========================================
+ Hits 1292 1793 +501
+ Misses 1052 948 -104
| Impacted Files | Coverage Δ | |
|---|---|---|
| examples/lib/scopeQuery.js | 18.51% <ø> (ø) |
|
| src/Modules.js | 100.00% <ø> (ø) |
|
| src/modules/WebglDistort/Module.js | 2.29% <0.00%> (ø) |
|
| src/ui/SetInputStep.js | 12.90% <0.00%> (-1.39%) |
:arrow_down: |
| src/modules/ColorHalftone/Module.js | 3.63% <3.63%> (ø) |
|
| examples/lib/defaultHtmlStepUi.js | 11.35% <4.08%> (-0.85%) |
:arrow_down: |
| examples/lib/intermediateHtmlStepUi.js | 11.11% <5.55%> (+0.94%) |
:arrow_up: |
| examples/lib/insertPreview.js | 13.15% <20.00%> (-0.36%) |
:arrow_down: |
| src/util/getImageDimensions.js | 20.00% <20.00%> (ø) |
|
| src/util/isGif.js | 20.00% <20.00%> (ø) |
|
| ... and 100 more |
@publiclab/is-reviewers
Woah. Why was extra manipulation called before changePixel?
Is it not the case with other modules?
It should not be. If it is then it is a serious issue,
Is it?
Sorry for the late reply. Yes I think it is . Is there a need to open an issue for the same.
Yeah there is a need to open an issue. Do you want to do this or should I do it?
Go Ahead