community-toolbox

community-toolbox copied to clipboard

I was looking at some old and very stuck issues which I'd love to fix, but are really obscure. And sometimes I get an insight months or years later and fix one. I was thinking it'd be fun to post a "hall of fame" of extremely stuck issues which we've almost given up on. Sometimes people are in a mood to take one on. Sometimes a fresh look is worth it.

Here are some of mine! 😅

• https://github.com/publiclab/inline-markdown-editor/pull/52
• https://github.com/publiclab/plots2/pull/5655

I'm sure there are more!

What do folks think of this? It could just be a unique tag like hall-of-fame 🙈

Hello @jywarren , I have gone through this issue, it really is hard for a beginner to start off working on this issue 😢 , can you tell me from where should I start working on this issue. I would then like to work on this 😄

@jywarren Actually hall-of-fame issue label is a considerably good idea, the other thing that we can do is showing that list to the page (where the issues will be filtered following the similar approach as of stale issues') but I don't think that would be the most suitable thing to do...what do you think?

@pydevsg As it is not quite sure what should be done as of now, let's wait for some input...suggestions are welcome though :)

I will wait for it :)

I think it could go at the very bottom of the page, as it's kind of ideally something people might tackle once they are VERY familiar with the codebase.

@pydevsg perhaps you may want to take on another issue that is designed for newcomers? You can check https://code.publiclab.org and look for one of the first-timers-only issues there. Or we can make you one if there are none available?

On Fri, Aug 23, 2019 at 8:24 AM Sudipto Ghosh [email protected] wrote:

I will wait for it :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/community-toolbox/issues/257?email_source=notifications&email_token=AAAF6J4UQTN3GPNYSDRZHFDQF7JEVA5CNFSM4IOHPM3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5AB2AI#issuecomment-524295425, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6JYNXXJA4MG22MXDWZLQF7JEVANCNFSM4IOHPM3A .

Thankyou @jywarren , I will try to understand the codebase. For time being i will be happy if you provide few first timers issues to me :)

Hi @pydevsg, you can go ahead with this issue...do the required changes as shown in the issue description, run grunt build, commit & push and create a PR for it. Ping me if you need any help :smile:

@jywarren Hmm, putting it at the bottom sounds good, but how "old" the issue should be to be included in that list?... Maybe more than 2-3 months?

Here's another for the hall of fame! https://github.com/publiclab/plots2/pull/3007

Ah, we can drive it off of a label like hall-of-fame to keep this pretty simple 😄 How about that?

Adding hall-of-fame label would be more customizable because if we decide to add a list, that would be filtering issues based on the time the issue was last updated...in some cases, we might not want to include all of that issues to the hall-of-fame.

Also, if we end up adding a label for the hall of fame issues, we can show that list to the bottom of the page just like fto and fto-candidate list. This would give us a place better explain what they are all about...what do you think?

This sounds great. Thank you!

On Fri, Aug 23, 2019 at 8:33 PM Rishabh Rawat [email protected] wrote:

Adding hall-of-fame label would be more customizable because if we decide to add a list, that would be filtering issues based on the time the issue was last updated...in some cases, we might not want to include all of that issues to the hall-of-fame.

Also, if we end up adding a label for the hall of fame issues, we can show that list to the bottom of the page just like fto and fto-candidate list. This would give us a place better explain what they are all about...what do you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/community-toolbox/issues/257?email_source=notifications&email_token=AAAF6J44LEA2YX3VU7AR44LQGB6TZA5CNFSM4IOHPM3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5BTVNQ#issuecomment-524499638, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J3FOXVURGCPY23UQL3QGB6TZANCNFSM4IOHPM3A .

OK, we've made the label! https://github.com/publiclab/plots2/labels/hall-of-fame

Adding mockup idea from @Rishabh570 -- thanks!

And i believe we should try to get these for all such labeled issues across the org, just like we do here for the first-timers-only issues:

https://github.com/publiclab/community-toolbox/blob/8b2530f2a7c7d9da696fc4e9ed1fda6a87ea341b/examples/demo.js#L57-L58