PublicLab.Editor

PublicLab.Editor copied to clipboard

…ts being overlayed on Insert Image popup.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
• [x] code is in uniquely-named feature branch and has no merge conflicts
• [x] PR is descriptively titled
• [x] PR body includes fixes #0000-style reference to original issue #
• [x] ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

Issue: #9442

Weird that the tests are failing here, I will close and reopen. Thanks @Priyaraj17

Shall I make another PR?

no @Priyaraj17, lets try and debug here, thanks

Okay sure.

@Priyaraj17 looks like this test has been failing on a number of PRs for a while now...I will check if there is an issue for that and open one if not. The test needs to be fixed on a different PR and after that your tests should be passing

Found the issue opened here https://github.com/publiclab/PublicLab.Editor/issues/683

@cesswairimu okay thank you so much. I will also take a look into this.