PublicLab.Editor

PublicLab.Editor copied to clipboard

The problem arose post https://github.com/publiclab/PublicLab.Editor/pull/636 Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• [ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
• [ ] code is in uniquely-named feature branch and has no merge conflicts
• [ ] PR is descriptively titled
• [ ] PR body includes fixes #0000-style reference to original issue #
• [ ] ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

The problem was with module 1 and module 5

This looks great. I also noticed the toolbar in the rich text module is not consistent...

could it be somewhere around here?

https://github.com/publiclab/PublicLab.Editor/blob/cf1fc4a9c4b70afaede856bac214e27388ab6cfa/src/adapters/PublicLab.Woofmark.js#L372

we don't have to solve this here. but just thinking it might be easy to add.

could it be somewhere around here?

https://github.com/publiclab/PublicLab.Editor/blob/cf1fc4a9c4b70afaede856bac214e27388ab6cfa/src/adapters/PublicLab.Woofmark.js#L372

we don't have to solve this here. but just thinking it might be easy to add.

@jywarren yes, I noticed that. I thought it would be better if we make a separate PR..

@jywarren Yes