Peter Thomas

Results 357 comments of Peter Thomas

@jandry okay, agreed with the approach. but trying to make sure - see screenshot below - this should be reverted right ?

@jandry well, the attempt to run the docker push failed and I have no idea why. the login step (and credentials) were not changed at all, and they seem ok...

@jandry and the "old" script worked: https://github.com/karatelabs/karate/actions/runs/9401298251/job/25892764841 https://hub.docker.com/layers/karatelabs/karate-chrome/1.5.0.RC5/images/sha256-59e8d14e3c0c3f53509f3abfd027e2194a8288679a02250f8501729f0a21a238

@jandry please just open a new PR, because I don't know buildx and where to use the `--push` flag or if it is needed. I think you should be easily...

I agree that having a utility function to aggregate reports is good to have. one challenge is if tests started at different times - how do we calculate the total...

@jandry sorry that's the wrong file. the change needs to be made in https://github.com/karatelabs/karate/blob/6f162bbb1a20e955a4b8b1ba82bb53196bdb833b/.github/workflows/maven-release.yml I would have done it but I don't know the syntax as I said before. anyway...

@daviddavidgit failed with a different error :( https://github.com/karatelabs/karate/actions/runs/9501098584/job/26185805847#step:7:233

update: have reverted to old state, since we don't have a solution yet: https://github.com/karatelabs/karate/commit/351c4d27b63cc6a109262c4cac26f9ab96e5b962

@sergy8612 I think it is an interesting idea. if you are ok to submit a PR with a nice sample, I will certainly review it and consider it for merge....

@sergy8612 the normal PR process works: https://github.com/karatelabs/karate/blob/master/.github/CONTRIBUTING.md