PT-Plugin-Plus icon indicating copy to clipboard operation
PT-Plugin-Plus copied to clipboard

Fix Search Page sizing on Mobile

Open PrivatePasta opened this issue 4 years ago • 10 comments

Device: POCO X3 Pro Resolution: 2400x1080 Browser: Kiwi Browser PTPP Version: v.1.5.2

Is your feature request related to a problem? Please describe. The Search Page on mobile is very congested because of the multiple columns. Especially the comments column which does not need to be so long. Because of this, important information like the full torrent name is hidden (group name is obviously important) and the only way to fix it is by going to each page to check the full name.

Describe the solution you'd like Give us the option to add or remove columns in each page so that we can have it fit every device.

Describe alternatives you've considered Switching to landscape mode. Doesn't fix the issue.

Additional context This is what it look like when trying to search anything. As you can see the trailing part of the torrent title is hidden and I'd like to change that
Screenshot_20211022-005911
This is with "Desktop Mode" on because PTPP is genuinely unusable without it.

PrivatePasta avatar Oct 21 '21 19:10 PrivatePasta

https://github.com/ronggang/PT-Plugin-Plus/pull/915 Fixed in dev

ted423 avatar Oct 23 '21 18:10 ted423

Are you sure? I'm on version 1.5.2.3f9c990 and it looks like this for me. I followed the Developers Instructions and used dev branch.

Screenshot_20211030-020628

PrivatePasta avatar Oct 29 '21 20:10 PrivatePasta

Tried again with the latest version - 1.5.2.139a742 - and it's the same as above. My device details, if it matters, are in the first comment of this issue. Also it seems that the fix in #915 is only to change the column header. While that was done, it did not shorten the column enough and my problem still persists. Please re-open this issue.

PrivatePasta avatar Oct 29 '21 20:10 PrivatePasta

@PrivatePasta So, use CMT?

ted423 avatar Oct 30 '21 01:10 ted423

CMT?

PrivatePasta avatar Oct 30 '21 07:10 PrivatePasta

CMT?

short for word comment, but I don't think it's necessary.

The main point for this issue is too much columns in table, and the column headers are not editable. At now, we add css text-overflow: ellipsis; and title attribute for title columns. it works well in desktop but not mobile, because the browser in mobile not listen to mouseover event.

maybe when the width is too small, we can hide some columns or just let the user choose which columns they want.

Rhilip avatar Oct 30 '21 08:10 Rhilip

@Rhilip yeah that was my suggestion. You could hard-code the comment column to be of shorter width. But a better option would be to give users the option as to which columns are shown.

PrivatePasta avatar Oct 30 '21 09:10 PrivatePasta

@PrivatePasta not too many option. Have you tried horizontal screen

ted423 avatar Oct 30 '21 09:10 ted423

@ted423 Yeah, I mentioned in my first comment on the issue. Landscape doesn't change anything cus the column stays the same size.

PrivatePasta avatar Oct 30 '21 10:10 PrivatePasta

Since the master and dev branch is most like the stable status, and The ui framework is too old ( Vuetify v1.5 )

So I don't want to do this now, and I want to fix this issue in PTPP v2 ( the next branch )

Rhilip avatar Nov 04 '21 08:11 Rhilip