proxy-wasm-cpp-sdk icon indicating copy to clipboard operation
proxy-wasm-cpp-sdk copied to clipboard

Published 20 hours ago • verified publisher icon proxy-wasm

Update protobuf libraries

Open mpwarres opened this issue 2 years ago • 2 comments

As pointed out in https://github.com/envoyproxy/envoy/issues/29546, proxy-wasm-cpp-sdk is using v3.9.1 of the protobuf library, which is from 2019. We should update it.

mpwarres avatar Sep 11 '23 14:09 mpwarres

+1 we should do this. I tried as part of my emsdk update (to fix a zlib issue) and I ran into some issues propagating copts: https://github.com/proxy-wasm/proxy-wasm-cpp-sdk/pull/157#discussion_r1297643204

I propose we finish the emsdk update first, then try to bump protobuf.

martijneken avatar Sep 13 '23 03:09 martijneken

Updating the protobuf library should make the hack mentioned in these instructions obsolete, since protobuf added support for building with Emscripten in protocolbuffers/protobuf@8e869f7.

As part of updating protobuf, the instructions linked above should be removed.

mpwarres avatar Aug 04 '24 20:08 mpwarres