python-cmudict icon indicating copy to clipboard operation
python-cmudict copied to clipboard

Published 20 hours ago • verified publisher icon prosegrinder

Adding type hints

Open colinpollock opened this issue 5 years ago • 1 comments

First, thanks for making this! I was very happy to be able to drop a dependency on NLTK.

I'm adding type hints to the repo in which I'm using CMUDICT and I'm getting errors from mypy because of missing types.

The guts of this package, cmudict/init.py, is only 83 lines of code. Would you be interested in having type hints? If so, I can submit a pull request.

colinpollock avatar Feb 10 '20 21:02 colinpollock

Definitely a welcome PR! Let me know if you need anything. This is such a small package, I haven't invested the time in building out guidelines, etc.

davidlday avatar Feb 11 '20 01:02 davidlday