promu icon indicating copy to clipboard operation
promu copied to clipboard

Published 20 hours ago • verified publisher icon prometheus

Add codesign utility function

Open gitperr opened this issue 1 year ago • 3 comments

Calls on rcodesign to code sign a target binary.

TODO:

  • [x] ~Add tests~ (no good way of doing this, rcodesign verify does not work very well with this warning: (the verify command is known to be buggy and gives misleading results; we highly recommend using Apple's tooling until this message is removed)
  • [x] Other, based on feedback

gitperr avatar Feb 15 '24 19:02 gitperr

@SuperQ wanna take a look?

gitperr avatar Feb 17 '24 19:02 gitperr

Squashed, will make changes to https://github.com/prometheus/node_exporter/pull/2916 as well to accompany this.

gitperr avatar Feb 18 '24 13:02 gitperr

Updated README as well now. And squashed again. Should be good to go, please take another look.

This should be merged before https://github.com/prometheus/node_exporter/pull/2916 to make pipelines start working properly with promu codesign

gitperr avatar Feb 18 '24 14:02 gitperr

@roidelapluie does this PR look good?

gitperr avatar Mar 19 '24 21:03 gitperr

Is there anyone else we can ask review from? If roidelapluie is busy, maybe someone else could take a look?

gitperr avatar Apr 14 '24 14:04 gitperr