docs icon indicating copy to clipboard operation
docs copied to clipboard

Update overview.md

Open sjnester opened this issue 3 years ago • 5 comments

I found the first sentence in "### What are metrics ?" awkward especially the use of the word "mean". Since I tripped over it I thought it was only fair to propose a small edit.

sjnester avatar Nov 08 '21 22:11 sjnester

Thanks! Can you please sign the DCO?

RichiH avatar Nov 16 '21 17:11 RichiH

Thanks! Can you please sign the DCO?

Hi - I'm new at this - can you point me to where I need to sign? Thanks!

sjnester avatar Nov 16 '21 18:11 sjnester

@sjnester: I've run into exactly the same issue with that sentence. My PR was also rejected.

I'm trying to persuade the devs here to make the contribution process easier, and DCO is the thorn in the side here. See #2118.

tredondo avatar Apr 06 '22 08:04 tredondo

This needs a DCO sign-off. You can use git commit -s --amend to add it.

SuperQ avatar Apr 07 '22 00:04 SuperQ

@sjnester https://github.com/prometheus/docs/pull/2061/checks?check_run_id=4145616864 also shows a howto and links to https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Does that help?

RichiH avatar May 27 '22 12:05 RichiH