Dario Tranchitella

Results 154 comments of Dario Tranchitella

> However, I don't think I like the 'magic' behaviour of empty `host` and(?) `port` meaning externally managed. Someone could omit host/port by accident without actually intending to use Kamaji...

> 1. We should set [externalManagedControlPlane](https://cluster-api.sigs.k8s.io/developer/architecture/controllers/control-plane#optional-status-fields) in the status when selected A bit confused, here. For our controller (Kamaji) it's already done, nothing's expected from the Proxmox CAPI provider. >...

Dunno who to ping here, I think I addressed all the required changes.

@wikkyk no worries, no pressure at all, I truly understand the efforts in maintaining open source, especially considering summer has approached. I addressed the changes you requested, and noticed e2e...

@mcbenjemaa I just fixed the broken generated files, an e2e would be cool despite it seems a bit flaky according to the latest runs. I can try also to provide...

@mcbenjemaa absolutely, it's on my todo list!

Sharing also here just a reference to get this working with Kamaji as externally managed Control Plane ```yaml apiVersion: cluster.x-k8s.io/v1beta1 kind: Cluster metadata: name: proxmox-quickstart namespace: default spec: clusterNetwork: pods:...

May I work on this? I'd like to contribute to the project.

I'm very keen on getting this supported by Kamaji, I'm just worried about the extra LBs we could get allocated since CAPZ doesn't allow skipping the generation of the Kubernetes...

👋🏻 @rpahli I'd like to help you here with this, may I ask you to get in touch? You can find my contacts from LinkedIn, or by extracting the email...