cdncheck icon indicating copy to clipboard operation
cdncheck copied to clipboard

domains, ports and urls support

Open LuitelSamikshya opened this issue 3 years ago • 2 comments
trafficstars

closes #44

LuitelSamikshya avatar Sep 28 '22 23:09 LuitelSamikshya

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 28 '22 23:09 sonarqubecloud[bot]

Here I believe it would be better if we were using the dnsx libs which would accept multiple resolvers and different types of dns queries

brenocss avatar Oct 04 '22 15:10 brenocss

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 29 '22 15:11 sonarqubecloud[bot]

@brenocss Unfortunately I'm not sure it's actually possible as dnsx uses cdncheck (import loop)

Mzack9999 avatar Nov 29 '22 16:11 Mzack9999

would be better if we deprecated the idead of cdncheck-cli, and use httpx and naabu for this purpose(cdn-check), cause it already do http request or dns requests with multiple resolvers and threads, and we could also save 1 dns request and 1 http request for each host. cdn-check would be just a lib that check for the http-response and dns response and check if is a cdn or not

brenocss avatar Nov 29 '22 17:11 brenocss

@brenocss I think it can still be handy for filtering ips/cidrs within a pipeline

Mzack9999 avatar Dec 01 '22 15:12 Mzack9999

Closing as this needs to be reworked with updated information.

ehsandeep avatar Jan 23 '23 11:01 ehsandeep

@brenocss Unfortunately I'm not sure it's actually possible as dnsx uses cdncheck (import loop)

Can't we use retryabledns?

brenocss avatar Feb 17 '23 22:02 brenocss