contour icon indicating copy to clipboard operation
contour copied to clipboard

Published 20 hours ago • verified publisher icon projectcontour

internal/dag: 0s HTTPRoute timeout disables the timeout

Open skriss opened this issue 1 year ago • 2 comments

In Gateway API, a timeout specified as 0s (or any other explicitly zero-valued duration string) should disable the timeout rather than use the default value.

Closes #6373.

skriss avatar Apr 23 '24 14:04 skriss

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.59%. Comparing base (056d880) to head (364fb4b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6375   +/-   ##
=======================================
  Coverage   81.59%   81.59%           
=======================================
  Files         133      133           
  Lines       15861    15865    +4     
=======================================
+ Hits        12941    12945    +4     
  Misses       2624     2624           
  Partials      296      296
Files Coverage Δ
internal/dag/gatewayapi_processor.go 93.21% <100.00%> (+0.01%) :arrow_up:

codecov[bot] avatar Apr 23 '24 14:04 codecov[bot]

Ran GWAPI conformance test locally with a longer delay on the HTTP request (30s to exceed the default Envoy 15s request timeout) and longer conformance suite timeouts to verify this is working as expected.

skriss avatar Apr 23 '24 14:04 skriss