contour

contour copied to clipboard

Adds checks to verify resources are eventually created with the expected status, where missing. Without these checks, it's unknown whether the "CreateAndWaitFor" method was successful or timed out waiting for the desired condition.

Apr 15 '24 21:04 skriss

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.59%. Comparing base (3c79035) to head (492416e).

@@           Coverage Diff           @@
##             main    #6347   +/-   ##
=======================================
  Coverage   81.59%   81.59%           
=======================================
  Files         133      133           
  Lines       15861    15861           
=======================================
  Hits        12941    12941           
  Misses       2624     2624           
  Partials      296      296           

Apr 15 '24 21:04 codecov[bot]

Considering nearly every invocation of the "CreateAndWaitFor" methods ignore the first returned argument, I'm going to look at dropping it from the API. Tests that need to re-fetch the Kube resource from the apiserver after creation can do it explicitly. Means all of these can become one-liners.

Apr 15 '24 21:04 skriss