contour
contour copied to clipboard
[WIP] change default xDS server to envoy
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81.20%. Comparing base (
a740314) to head (c7847f3). Report is 7 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #6146 +/- ##
==========================================
+ Coverage 81.19% 81.20% +0.01%
==========================================
Files 133 133
Lines 15803 15803
==========================================
+ Hits 12831 12833 +2
+ Misses 2678 2677 -1
+ Partials 294 293 -1
| Files | Coverage Δ | |
|---|---|---|
| internal/contourconfig/contourconfiguration.go | 98.69% <100.00%> (ø) |
|
| pkg/config/parameters.go | 88.03% <100.00%> (ø) |
The Contour project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 14d of inactivity, lifecycle/stale is applied
- After 30d of inactivity since lifecycle/stale was applied, the PR is closed
You can:
- Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
- Mark this PR as fresh by commenting or pushing a commit
- Close this PR
- Offer to help out with triage
Please send feedback to the #contour channel in the Kubernetes Slack
One note, feature tests have not yet been updated to use the envoy xds server (ref. #6254). If folks feel like that should be a prerequisite for changing the default, I'll work on getting that done. I've done a quick test of it and looks like there will be a number of test changes required.
Update: featuretests updated in https://github.com/projectcontour/contour/pull/6255
@sunjayBhatia thanks for the review on #6255; once this one is approved as well I'll merge 'em both.