contour

contour copied to clipboard

What steps did you take and what happened: Create a Gateway with a name longer than 63 characters Observe that no resources are created, errors in the logs

The problem is that we set some labels on resources based on the Gateway name, but Gateway names can be up to 253 characters while labels can be at most 63. We need some kind of hashing to handle longer names.

There is a new test in Gateway conformance that adds a Gateway with a long name, adding to the next milestone so we're aware for the next bump

One thing we may want to bring upstream here: GEP-1762 calls for labeling in-cluster Gateway resources (ref. https://gateway-api.sigs.k8s.io/geps/gep-1762/#automated-deployments) in the same way that Contour already does with its own custom label, but doesn't describe what to do in this scenario where the Gateway name is too long. That should probably be part of the spec.

ah yeah that is a very good point, I forgot that GEP specifically adds the gateway name as a label, definitely something to bring up to the community

added https://github.com/kubernetes-sigs/gateway-api/issues/2592

TODO add a note to Contour Gateway API docs about this open issue

Added a docs PR to document this for Contour; awaiting resolution of upstream issue, hopefully with guidance on how implementations should handle this situation.