contour

contour copied to clipboard

Currently, disabling external auth on direct responses doesn't work because we handle the case of direct responses in a different branch of the code while creating the Envoy route.

This PR fixes this bug.

P.S: For rate limiting it turns out it is an issue because direct responses don't care about the rate limit filter. I added tests to confirm that as well.

Nov 14 '23 14:11 shadialtarsha

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dba50bc) 78.56% compared to head (aebe4fa) 78.57%. Report is 40 commits behind head on main.

@@           Coverage Diff           @@
##             main    #5962   +/-   ##
=======================================
  Coverage   78.56%   78.57%           
=======================================
  Files         139      139           
  Lines       19615    19623    +8     
=======================================
+ Hits        15411    15419    +8     
  Misses       3901     3901           
  Partials      303      303           

Nov 14 '23 14:11 codecov[bot]

@davinci26 I don't have permissions to do that

Nov 14 '23 16:11 shadialtarsha

@shadialtarsha done

Nov 14 '23 16:11 davinci26

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 14d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

• Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
• Mark this PR as fresh by commenting or pushing a commit
• Close this PR
• Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

Nov 29 '23 00:11 github-actions[bot]

Still fresh

Dec 08 '23 21:12 shadialtarsha

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 14d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

• Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
• Mark this PR as fresh by commenting or pushing a commit
• Close this PR
• Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

Dec 29 '23 00:12 github-actions[bot]

refresh

Jan 03 '24 13:01 shadialtarsha

@shadialtarsha if you can address @sunjayBhatia's comments we should be able to get this into the upcoming release.

Jan 04 '24 20:01 skriss

@skriss when is the next release? @shadialtarsha is on PTO till next week, so I wanted to see if I should push the changes myself or we can wait for it

Jan 04 '24 20:01 davinci26

Release will be end of Jan (est. 1/31), with an RC a week or so beforehand. I'll leave it up to you but there should be time.

Jan 04 '24 20:01 skriss

We got time then I guess, will leave it to @shadialtarsha when he comes back

Jan 04 '24 20:01 davinci26

@davinci26 @shadialtarsha just a reminder that the release date is approaching, it'd be great to get this PR updated so we can include it.

Jan 19 '24 15:01 skriss

Bumping to 1.29.

Feb 07 '24 17:02 skriss

Merged #6426, closing this one out.

May 08 '24 20:05 skriss