contour icon indicating copy to clipboard operation
contour copied to clipboard

Published 20 hours ago • verified publisher icon projectcontour

Add GatewayClass finalizer

Open izturn opened this issue 3 years ago • 2 comments

Please describe the problem you have When a controller starts managing a Gateway, it is supposed to update its GatewayClass with a finalizer so that the GatewayClass cannot be deleted while there are still Gateways referring to it.

https://gateway-api.sigs.k8s.io/v1alpha2/references/spec/#gateway.networking.k8s.io/v1alpha2.GatewayClass

Whenever one or more Gateways are using a GatewayClass, implementations MUST add the gateway-exists-finalizer.gateway.networking.k8s.io finalizer on the associated GatewayClass. This ensures that a GatewayClass associated with a Gateway is not deleted while in use.

izturn avatar Sep 19 '22 13:09 izturn

Thanks @izturn, looks like this is a dupe of #3866 but we can close the old one out and track here.

skriss avatar Sep 19 '22 14:09 skriss

@skriss thx, I saw your comments for https://github.com/envoyproxy/gateway/pull/373, pls show me how to implement it for contour, I like to implement it

izturn avatar Sep 20 '22 01:09 izturn

There is currently some upstream discussion on whether this should be part of the Gateway API spec or not (https://github.com/kubernetes-sigs/gateway-api/issues/1411), let's hold off on doing anything until that is resolved.

skriss avatar Sep 27 '22 14:09 skriss

got it

izturn avatar Sep 29 '22 02:09 izturn

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Dec 31 '22 00:12 github-actions[bot]

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Jan 31 '23 00:01 github-actions[bot]