contour icon indicating copy to clipboard operation
contour copied to clipboard

Published 20 hours ago • verified publisher icon projectcontour

crd/ContourDeployment: Add field 'podAnnotations'

Open izturn opened this issue 3 years ago • 5 comments

add the field podAnnotations to crd/ContourDeployment to enable adding more annotations to pod/envoy, if there are the same name key-value pairs exist, it will be overwritten

Signed-off-by: Gang Liu [email protected]

izturn avatar Aug 19 '22 08:08 izturn

Marking this PR stale since there has been no activity for 14 days. It will be closed if there is no activity for another 30 days.

github-actions[bot] avatar Sep 03 '22 00:09 github-actions[bot]

ping @skriss @tsaarni

izturn avatar Sep 05 '22 03:09 izturn

ping again @skriss @tsaarni

izturn avatar Sep 08 '22 01:09 izturn

needs a main merge as well

sunjayBhatia avatar Sep 08 '22 14:09 sunjayBhatia

Codecov Report

Merging #4681 (066abf0) into main (0467b84) will increase coverage by 0.01%. The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4681      +/-   ##
==========================================
+ Coverage   76.07%   76.08%   +0.01%     
==========================================
  Files         140      140              
  Lines       16880    16888       +8     
==========================================
+ Hits        12842    12850       +8     
  Misses       3786     3786              
  Partials      252      252
Impacted Files Coverage Δ
internal/provisioner/controller/gateway.go 56.22% <100.00%> (+0.79%) :arrow_up:
internal/provisioner/model/model.go 92.20% <100.00%> (+0.10%) :arrow_up:
...nternal/provisioner/objects/dataplane/dataplane.go 87.84% <100.00%> (+0.05%) :arrow_up:

codecov[bot] avatar Sep 09 '22 06:09 codecov[bot]

Marking this PR stale since there has been no activity for 14 days. It will be closed if there is no activity for another 30 days.

github-actions[bot] avatar Sep 24 '22 00:09 github-actions[bot]

codegen is unhappy, what can i do?

izturn avatar Oct 14 '22 02:10 izturn

codegen is unhappy, what can i do?

I re-ran it and it went through successfully

skriss avatar Oct 14 '22 02:10 skriss

codegen is unhappy, what can i do?

I re-ran it and it went through successfully

ok, thx

izturn avatar Oct 14 '22 02:10 izturn

@sunjayBhatia mind taking a quick look here? OK to merge from my PoV.

skriss avatar Oct 17 '22 17:10 skriss