capsule icon indicating copy to clipboard operation
capsule copied to clipboard

add: ignore-user-group annotation logic

Open gkarthiks opened this issue 3 years ago • 3 comments

Signed-off-by: gkarthiks [email protected]

Fixes: #567

gkarthiks avatar Jun 01 '22 21:06 gkarthiks

Deploy Preview for capsule-documentation ready!

Name Link
Latest commit 35fab84092debd5293922eeb31a27289cba95b7f
Latest deploy log https://app.netlify.com/sites/capsule-documentation/deploys/6297da1ff3c0060009225d60
Deploy Preview https://deploy-preview-576--capsule-documentation.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jun 01 '22 21:06 netlify[bot]

Also, please amend commit message input: add: ignore-user-group annotation logic: it doesn't follow any rule in the Conventional Commit guide.

prometherion avatar Jun 08 '22 13:06 prometherion

@prometherion

this was my understanding to fix this,

Requirements:

I am having the ArgoCD's service account getting created in the "kube-system" namespace (the default behavior of the ArgoCD). When I am trying to create the 'tenant' and 'namespaces' via GitOps (using ArgoCD) this is not working, because by default capsule ignored the kube-system service account.

The proposal was to add another field in the capsuleconfiguration something like this.

But then we decided to move forward with the capsule.clastix.io/ignored-user-groups annotations and this will hold the list of user groups that needs to be ignored(even though if they are provided as the tenant owners).

So with the above approach, why would you need to ignore the 'kube-system' sa by default. Because this would result in the same behaviour as early if I do not want to ignore that kube-system service account.

gkarthiks avatar Jul 07 '22 16:07 gkarthiks

Closing this due to stale activity.

prometherion avatar Sep 26 '23 15:09 prometherion