sgqlc icon indicating copy to clipboard operation
sgqlc copied to clipboard

aiohttp endpoint

Open barbieri opened this issue 8 years ago • 3 comments

Provide an endpoint using https://aiohttp.readthedocs.io/en/stable/

barbieri avatar Jan 17 '18 18:01 barbieri

would be nice to provide subscriptions using its websockets.

barbieri avatar Feb 24 '19 16:02 barbieri

Here is something good enough to start with : https://github.com/profusion/sgqlc/discussions/162#discussioncomment-1040386. Users of this module that use asyncio can vendor that class in.

I am unfortunately still not comfortable with this code base and it's style to integrate this in without spending too much time on it. I am however coming back to this repo more and more often so I might find some time in the future to integrate it.

YassineElbouchaibi avatar Jul 23 '21 03:07 YassineElbouchaibi

thanks for the snippet. It will be nice to get a PR with that, you can run through flake8 to help with the style preferences (I know that pain).

I'm okay with typing, we just lack it due timing: when I started this project, typing wasn't widely used and the project core (sgqlc.types and sgqlc.operation) use Metaclass, which renders typing useless :-/ But in areas where it's feasible to add without much effort (end points, command line tools), it's desired to add typing.

barbieri avatar Jul 23 '21 18:07 barbieri