bpmn-visualization-js icon indicating copy to clipboard operation
bpmn-visualization-js copied to clipboard

[BUG] Elements of a participant without a displayed Pool are not filtered

Open csouchet opened this issue 3 years ago • 2 comments

  • Use email voting BPMN diagram from BPMN spec in the demo.
  • Filter with the participant id (without displayed pool)

-> Result: After filtering, the elements of the process (referencing by the participant) are not displayed ❌

Reproduction

The "Email Voting" process semantic has 2 participants (TODO attach file).

  • "email voting" black box pool with participant id _6-782
  • "not displayed pool", participant id _1276277380736, processRef _6

The BPMN diagram can be retrieved in the archive in the "Informative Documents" paragraph in https://www.omg.org/spec/BPMN/2.0/About-BPMN/ "BPMN 2.0 examples non-normative machine readable files" dtc/10-06-03.zip

email voting process

When using the demo of [email protected] (access the urls below then load the bpmn diagram)

  • ✔️ Filtering the black box pool: https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/v0.25.2/demo/load-and-navigation/index.html?bpmn.filter.pool.ids=_6-782
  • ❌ filtering the "not displayed pool" --> error with message Cannot load the BPMN diagram: No matching pools for ids [_1276277380736] https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/v0.25.2/demo/load-and-navigation/index.html?bpmn.filter.pool.ids=_1276277380736

csouchet avatar Jul 22 '22 09:07 csouchet

⚠️ I don't understand the issue title and the description is only mentioning a test to un-comment! Please describe the use case, provide a BPMN file to reproduce the problem and add screenshots. Without such information, I cannot evaluate the request. Thanks in advance.

The related test to un-comment is a unit test, so I guess we should have to add higher level tests (integration and/or e2e) to better exhibit the problem and ensure non-regression. And eventually additional parsing tests to ensure data are correctly transform within the model prior filtering them.

tbouffard avatar Aug 11 '22 13:08 tbouffard

Thanks for the update but the reproduction steps were to minimal. I added screenshots and a step-by-step procedure for reproduction. We cannot ask users to provide information we are not providing when core contributors create bug. Next time, please use the BUG template 😒 .

The tasks to do should be removed, they are currently related to non existing tests in the master branch.

tbouffard avatar Aug 16 '22 17:08 tbouffard