MiniDexed icon indicating copy to clipboard operation
MiniDexed copied to clipboard

Modulation Range Error

Open Banana71 opened this issue 1 year ago • 12 comments

If any modulation range is changed, the modulation can no longer be heard; the modulation only works again after blindly saving and reloading the performance. You can easily try it out with the performance 000011_SeventyOne, for example. Simply turn the modulation wheel all the way up until the sound has a lot of vibrato, then change the modulation range for the modulation wheel from 99 to 98 in the settings of TG1 and TG2 and you can no longer hear vibrato. The problem occurs with all types of modulation. (ModWheel, Breath Controller, Foot Controller, Aftertouch)

Banana71 avatar Nov 17 '23 17:11 Banana71

Thanks for reporting this issue @Banana71. Do you happen to know whether this works correctly in Dexed on the PC?

probonopd avatar Nov 17 '23 17:11 probonopd

In Dexed everything works as it should. Range changes are applied immediately, even when tones are pressed and held.

Banana71 avatar Nov 17 '23 17:11 Banana71

@dcoredump can you reproduce this on MicroDexed?

probonopd avatar Nov 17 '23 19:11 probonopd

I have to check this, give me some time. I think I know what's going wrong...

Thanks @Banana71 for deep testing and finding problems I never thought they may exist 😁

dcoredump avatar Nov 19 '23 05:11 dcoredump

I created a PR. Hope this fixes the problems. Cannot test - no keyboard right here.

dcoredump avatar Nov 20 '23 09:11 dcoredump

Hi Holger @dcoredump , Unfortunately the error is still there

Banana71 avatar Nov 20 '23 11:11 Banana71

Hi Holger @dcoredump , Unfortunately the error is still there

Hmpf... I found that the (wrong?) calls to controllers.refresh() were additionally also inside Synth_Dexed :( Can you try this version of Synth_Dexed?

dcoredump avatar Nov 20 '23 14:11 dcoredump

@Banana71 please try this build: MiniDexed_2023-11-20-8d1e592

It is built using the fixed version from the posting above.

probonopd avatar Nov 20 '23 18:11 probonopd

The error has changed. I set the Mod.Wheel to MAX, the sound has full vibrato. After adjusting the Mod.Wheel range from e.g. 99 to 80, the vibrato remains at MAX and the vibrato stops completely when you move the Mod.Wheel. In other words: you can adjust the range but the modulation remains at the old value. After moving the Mod.Wheel the modulation goes off and can no longer be restored.

Banana71 avatar Nov 20 '23 19:11 Banana71

Thanks for testing!

Ok, I need to get my MIDI keyboard from the rehearsal room to my lab at home for deeper inspection. I hope I can try to dive in deeper at next weekend.

dcoredump avatar Nov 21 '23 09:11 dcoredump

Hi Peter,

now I got some time for testing this with MicroDexed (see this video). On MicroDexed it works as expected. So the problem may be located inside MiniDexed?

Regards and merry xmas, Holger

dcoredump avatar Dec 23 '23 15:12 dcoredump

Thank you Holger for your effort.

Merry Christmas to you all 🎄 Peter

Banana71 avatar Dec 24 '23 15:12 Banana71

Good things come to those who wait. For whatever reason, probably due to the Glissando Effect Fix https://github.com/probonopd/MiniDexed/issues/889 , the modulation range parameterization now works. Thanks

Or does anyone have an explanation for why this suddenly works?

Banana71 avatar May 03 '25 11:05 Banana71

Glad to hear it works now! 👍

I don't have a better explanation.

probonopd avatar May 03 '25 11:05 probonopd

Or does anyone have an explanation for why this suddenly works?

Maybe I fixed it and forgot to tell this for upstream integration...

dcoredump avatar May 15 '25 06:05 dcoredump

Maybe this one? https://codeberg.org/dcoredump/Synth_Dexed/commit/b9fd3010f28ba248049315dbd81c887bdc3f3a38

soyersoyer avatar May 15 '25 11:05 soyersoyer