github-vscode-theme

github-vscode-theme copied to clipboard

Description

Hi

This is the markdown preview:

and it is the result of this markdown content:

I can confirm that this happens when all extensions (other than this one) are disabled.

Steps to reproduce

Just switch to the GitHub Dark High Contrast theme and preview a markdown content in vsCode.

Version

v6.3.4

Theme

GitHub Dark High Contrast

What type of font is used?

tks

this is also the case for me

Adding this to settings.json works as a hack.

"workbench.colorCustomizations": {
    "textPreformat.foreground": "#000000"
}

What type of font is used?

tks

https://www.jetbrains.com/lp/mono/

Adding this to settings.json works as a hack.

"workbench.colorCustomizations": {
    "textPreformat.foreground": "#000000"
}

Awesome, thank you. I changed your code to this:

"workbench.colorCustomizations": {
    "textPreformat.background": "#3d3d3d"
},

and this is the result:

Adding this to settings.json works as a hack.

"workbench.colorCustomizations": {
    "textPreformat.foreground": "#000000"
}

Awesome, thank you. I changed your code to this:

"workbench.colorCustomizations": {
    "textPreformat.background": "#3d3d3d"
},

and this is the result:

Ugh, after years of squinting at these unreadable blocks I've finally found a solution. Thanks!

@babakfp

Awesome, thank you. I changed your code to this:

"workbench.colorCustomizations": {
    "textPreformat.background": "#3d3d3d"
},

and this is the result:

Your fix looks great! I was looking on the contribution guide in the README and it asks that contributions try to stick to the colours listed in the Primer Design System. The closest colour to your suggestion of #3d3d3d on the colour sheet is #3d424d, which is called base-color-neutral-7.