preset-vite

preset-vite copied to clipboard

This pull request solves #46 by adding jsxImportSource to PreactPluginOptions. As a bonus, I changed prepublishOnly to prepare, which allows the package to be installed directly via Git and should not affect its behaviour when being published to npm.

bump

This PR has the right spirit, but does a whole lot more than just allowing jsxImportSource to be overwritten.

Is this referring to the additional 3 commits caused by fast forwarding the pull request to main?

You need to rebase your changes. The diff is quite mangled.

Should be fixed now.

@Interpause the comment to leave prePublish in still stands 😅 we want this so when we use npm publish we are sure we can't forget to use the latest build

@JoviDeCroock FWIW, prepare does run before a publish: https://docs.npmjs.com/cli/v8/using-npm/scripts#life-cycle-scripts

I would argue against prepare still though as there's no reason we need to run a build immediately after installing deps (which it does). That's just a nuisance, IMO.

Edit: I guess it facilitates installing from git, but meh. Do people do that often enough?

Say, its been a while. Actually, I think the changes made to allow configuring jsxImportSource is quite minor, such that it probably would not be too much trouble for a maintainer to just include it in a commit. If so, would it be fine to close this PR?

Could you please consider to merge the PR, as the changes had been cleaned up