Ivan Santos

Results 92 comments of Ivan Santos

@stefanprodan I could possibly work on that one if that is a valid request.

FYI, already tested it, it can be fixed by replacing the `cb()` line with: ```js if (typeof req.session.save == 'function') { req.session.save(function () { if (err) { cb(err); } cb();...

For instance, express-session only saves the data on `res.end`. Redirects are not included, and they recommend saving the session for redirect callbacks. https://github.com/expressjs/session/blob/master/index.js#L250

Related: https://github.com/expressjs/session/issues/360

I ended up implementing my own changes for the project. The next one I ended up using Koa2 which has async support out of the box, and it's working like...

I might be able to help but will take quite some time (Still refreshing my skills with go) 😂 If anyone else has the need for this feature asap.

What's going to be the client producer for the metrics? OpenTelemetry SDK or prom client?

I kinda prefer what ArgoRollout did with AnalysisTemplate ```yml apiVersion: argoproj.io/v1alpha1 kind: AnalysisTemplate metadata: name: success-rate spec: args: - name: application-name metrics: - name: success-rate successCondition: result.successRate >= 0.95 provider:...

Perhaps key/value with defaults would work well enough here? ```yaml - name: application-name value: myapp ```