posthtml-beautify icon indicating copy to clipboard operation
posthtml-beautify copied to clipboard

Published 20 hours ago • verified publisher icon posthtml

[feat]: preserve line breaks, make settings optional

Open andreyvolokitin opened this issue 7 years ago • 6 comments

https://github.com/Scrum/posthtml-beautify/issues/220

andreyvolokitin avatar Mar 28 '18 10:03 andreyvolokitin

This is not complete, I plan to add an edge case here, for this (so the line break is added to fix this)

andreyvolokitin avatar Mar 28 '18 13:03 andreyvolokitin

Fix for old node please

Scrum avatar Mar 29 '18 20:03 Scrum

I think this is because of await, which was introduced in Node 9. I suppose it is inside pre-existing tests. Could babel-polyfill solve the problem? BTW should I write tests for my features?

andreyvolokitin avatar Mar 30 '18 14:03 andreyvolokitin

Strange how it was not a problem before... There is await in the tests code at least since 2016, but also there are passing PRs after that as well. Maybe something happened and suddenly turned it into a problem? Probably not something in this PR...

andreyvolokitin avatar Mar 30 '18 14:03 andreyvolokitin

Hm. Clearly not an await, there are other passing tests with it. Not sure how is this possible because I didn't add any "new" syntax which would work only with "new node"...

andreyvolokitin avatar Mar 31 '18 09:03 andreyvolokitin

well, I'll figure it out. Thank you for your contribution - this is very important for this project.

Scrum avatar Apr 01 '18 11:04 Scrum