git-history icon indicating copy to clipboard operation
git-history copied to clipboard

Published 20 hours ago • verified publisher icon pomber

Set default font size for code lines

Open everdimension opened this issue 6 years ago • 0 comments

This change fixes line cropping that users may experience if they set custom font size in the browser settings

Problem explained in images:

What it looks like now:

Screen Shot 2019-10-25 at 13 42 11

The settings in chrome that I have (and that many other people may have):

Screen Shot 2019-10-25 at 13 42 33

What it looks like after the fix:

Screen Shot 2019-10-25 at 13 44 18

Why this fix is okay for a11y:

I want to emphasize that this is a quick fix that should ideally be temporary. It's best to later change the hardcoded height: 15px values to something that respects the current rem size.

At the same time, this quick fix is a good solution because you no longer see cropped text (which is hard to read by itself) and also if someone wishes to make their text larger, the zoom-in combo command++ still works.

everdimension avatar Oct 25 '19 11:10 everdimension