Peter Rowlands (변기호)

Results 230 comments of Peter Rowlands (변기호)
trafficstars

On the terminology question, the `reproduced` messages are from before experiments were released. I wrote them that way at the time since the initial development framing was "repro with saved...

There is an existing issue for setting `ff-only` https://github.com/iterative/dvc/issues/7675 These issues need to be resolved in scmrepo, basically we need to be able to provide our own gitconfig when doing...

What is the expected behavior of `dvc commit` when a repo has partial imports? Currently it will fail because there is no output file in the workspace ``` $ cat...

Also, this is semi-related to #8164, but IMO using `dvc pull` here to download and complete/un-partial the imports gets confusing, because subsequent `dvc pull`s do not download the import from...

> What if there was something in the workspace? It will give you the "output has changed are you sure you want to commit" prompt, and if you commit it...

For reference, @guysmoilov the dagshub repo in your example doesn't work for me, when I clone it there is no default remote configured so you can't `dvc pull` any data...

So the issue is that RetryClient defaults to retrying on all 5xx server errors. @skshetry has identified that this can be disabled by setting `retry_all_server_errors=False`. However, what we probably want...

This is fixed in the latest dvc-data/dvc-objects releases and will be available in the next DVC release. In the meantime, you can manually install the latest dvc-data to get the...

@guysmoilov you are correct, it should be `0.1.15`

We can probably disable the default pytest-celery worker ping timeout: https://github.com/celery/celery/blob/128f0027005f2bf9d4b93082049d2c96c2bcd879/celery/contrib/testing/worker.py#L63 it should just need to be set in our fixture: https://github.com/iterative/dvc/blob/7a0b3e93771c212fea3fa7d80f710877e9fdf958/tests/unit/repo/experiments/conftest.py#L15 _Originally posted by @pmrowla in https://github.com/iterative/dvc/issues/8108#issuecomment-1209294091_