Evolve icon indicating copy to clipboard operation
Evolve copied to clipboard

Add dockerfile

Open Driver-C opened this issue 1 year ago • 4 comments

I have already tested it

evolve

Driver-C avatar Aug 08 '24 09:08 Driver-C

Is this meaningfully different from executing npm run serve and accessing http://localhost:4040?

yarukishi avatar Aug 09 '24 14:08 yarukishi

Is this meaningfully different from executing npm run serve and accessing http://localhost:4040?

If only running locally, it's the same as npm run serve. Container images provide a way to run the evolve service in any environment, users can run the evolve service in their NAS device's docker, or run the evolve service in a Kubernetes cluster. Of course, this feature is not necessary for this project. If the project maintenance team is willing to try to accept container-related engineering features, I can also provide a Helm chart for deploying the evolve service to a Kubernetes cluster in the future. If you think it's unnecessary, then just close this PR

Driver-C avatar Aug 15 '24 03:08 Driver-C

The only person who can merge anything is Demagorddon, the original and primary developer, so final judgements on tooling upgrades (and all other PRs) are up to him.

yarukishi avatar Aug 15 '24 08:08 yarukishi

The only person who can merge anything is Demagorddon, the original and primary developer, so final judgements on tooling upgrades (and all other PRs) are up to him.

Understood, thanks.

Driver-C avatar Aug 15 '24 10:08 Driver-C