drei icon indicating copy to clipboard operation
drei copied to clipboard

feat: useVideoTexture enable hls support

Open netgfx opened this issue 1 year ago • 2 comments

Why

To add support for HLS in useVideoTexture

What

Added hlsjs as a dependency, allowed HTML video element of useVideoTexture to be enhanced by hlsjs in order to allow playback of variable bit rate videos.

Checklist

  • [ x] Documentation updated (example)
  • [ ] Storybook entry added (example)
  • [x ] Ready to be merged

netgfx avatar Feb 24 '24 22:02 netgfx

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 9:22pm

vercel[bot] avatar Feb 24 '24 22:02 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Feb 24 '24 22:02 codesandbox-ci[bot]

@CodyJasonBennett please take a look when you can. I have tested it out here: https://codesandbox.io/p/sandbox/white-smoke-wx5zht?file=%2Fsrc%2FApp.js%3A21%2C1 I would prefer if we could also return the HLS instance object so that people can use it to listen to hls events, but I couldn't make it return in a way that it didn't cause re-renders,let me know if you have some idea about this.

netgfx avatar Feb 25 '24 18:02 netgfx

@CodyJasonBennett I think I got it right this time, it should properly teardown now.

netgfx avatar Mar 29 '24 22:03 netgfx

:tada: This PR is included in version 9.103.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Mar 30 '24 07:03 github-actions[bot]