parse-torrent-title icon indicating copy to clipboard operation
parse-torrent-title copied to clipboard

'e' alone in title is parsed as language being English

Open platelminto opened this issue 3 years ago • 1 comments

If there's an 'e' alone in the title, very possible in Italian releases, the title will get split since it thinks it means the language is English.

Example:

  • Eu.gosto.do.Homem-Aranha.e.dai.1080p.AAC2.0.H264.mkv (made-up example)

As things are currently implemented, this makes sense - we do match a singular 'e' as a match for English as language. Though this we just want because we link languages to subtitle matches, and ESub is common.

We could remove E as a language match and add it explicitly to just subtitles? Though this makes things ugly.

platelminto avatar Feb 12 '22 15:02 platelminto

Thinking about it, any language match in the title screws things up.

If a movie is called The Nordic God, we'd match Nordic as the language, and break up the title.

We already have language as another post-probable-title attribute, but in this example there's just quality.

Either we add quality as a post-probable-title thing, but just 720p/1080p formats (have seen others later in the title), or we just move e to subtitles and live with things like nordic and stuff sometimes breaking titles.

platelminto avatar Feb 12 '22 15:02 platelminto

This specific example was fixed by adding 720p/1080p patterns to the post-probable-title regex. Similar examples can (hopefully) be fixed in the same way. Eventually, the awful way of handling languages & subtitles will cause too many issues and we'll fix it, but for now this is working.

platelminto avatar Jan 14 '24 17:01 platelminto