gensim icon indicating copy to clipboard operation
gensim copied to clipboard

Published 20 hours ago • verified publisher icon piskvorky

Fix word2vec doc-comment example of KeyedVectors usage, issue 2669

Open bvinesh opened this issue 5 years ago • 4 comments

Fixes #2669 Proposal is to remove use of get_tmpfile and (optionally) change to a temp directory instead. Let me know if you prefer a different approach and I will change it. Thank you.

bvinesh avatar Apr 11 '20 14:04 bvinesh

@mpenkov , much appreciated if this could be reviewed. This is my first PR. Please let me know if any changes are required. Thank you.

bvinesh avatar Apr 20 '20 11:04 bvinesh

Note to self: resolve conflict

mpenkov avatar Jun 29 '21 07:06 mpenkov

@bvinesh Yes, let's get rid of the temporary subdirectory and simply use the CWD. Are you able to finish this PR?

mpenkov avatar Jun 29 '21 09:06 mpenkov

@bvinesh we're planning a new release of Gensim soon. We could include this PR if you finish it – please let us know (or close it).

piskvorky avatar Feb 19 '22 19:02 piskvorky