ethereum-datetime icon indicating copy to clipboard operation
ethereum-datetime copied to clipboard

Published 20 hours ago • verified publisher icon pipermerriam

Sol v0.8

Open RyanRHall opened this issue 4 years ago • 5 comments

This PR does the following:

  • upgrades the DateTime contract to sol v0.8
  • introduces brownie as a dependency for running tests locally
  • adds a CI workflow to hopefully make future changes easier to manage

RyanRHall avatar Oct 20 '21 17:10 RyanRHall

Should I expect the CI workflow to run in this PR? I did a quick check of permissions and it seems it should be running.

pipermerriam avatar Oct 20 '21 17:10 pipermerriam

@pipermerriam I'm guessing we're not seeing the CI runs because the PR is cross-repository. Probably some github policy. When I make PRs onto our fork of the repo, CI works fine.

If you want to see the CI run before merging, you'll probably have to pull this branch, push up a local copy, and open a new PR.

RyanRHall avatar Oct 25 '21 15:10 RyanRHall

According to github, you should be able to "approve and run" @pipermerriam https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks#approving-workflow-runs-on-a-pull-request-from-a-public-fork

RyanRHall avatar Oct 26 '21 01:10 RyanRHall

Maybe try to rename ci.yml to ci.yaml?

lightclient avatar Oct 27 '21 18:10 lightclient

Maybe try to rename ci.yml to ci.yaml?

CI works fine. It's just disabled for outside contributors.

RyanRHall avatar Oct 28 '21 22:10 RyanRHall