webrtc
webrtc copied to clipboard
pion
Deletion of existing sample_builder implementation codes
This commit deletes the existing implementation of sample builder and replaces with raw jech implementation. No further modification has been made in this commit.
Description
Reference issue
Fixes #...
Codecov Report
Attention: 75 lines in your changes are missing coverage. Please review.
Comparison is base (
eed2bb2) 76.47% compared to head (fda9a22) 63.33%.
:exclamation: Current head fda9a22 differs from pull request most recent head 3913677. Consider uploading reports for the commit 3913677 to get more accurate results
| Files | Patch % | Lines |
|---|---|---|
| pkg/media/samplebuilder/samplebuilder.go | 73.95% | 52 Missing and 23 partials :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #2591 +/- ##
===========================================
- Coverage 76.47% 63.33% -13.15%
===========================================
Files 87 63 -24
Lines 9867 3758 -6109
===========================================
- Hits 7546 2380 -5166
+ Misses 1854 1229 -625
+ Partials 467 149 -318
| Flag | Coverage Δ | |
|---|---|---|
| go | ? |
|
| wasm | 63.33% <73.95%> (-1.22%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Sean-Der I made this draft push to show the state before i start making necessary additions and other iterations
@jech Could you also be a reviewer to this.
You've removed the tests? I don't agree, I think you should leave the tests. That way, when we adjust the tests, we know exactly how much the behaviour of the samplebuilder has changed, and we can decide whether the changes are acceptable or whether we should tweak the new samplebuilder.
@midepeter why is this being committed with you as the author? Since I am the author of the code, I would expect to be credited. Please use the --author flag to the git command to properly credit me as the author.
@jech oh, I will do that
sorry about that. This literally my first time in the open source space
I will do that. Apologies
Hey, I gave this a go and found two issues:
- You've removed some functionality like
WithMaxTimeDelaybut the options silently apply. I'm assuming this is what you meant when you said "to show the state before i start making necessary additions and other iterations" - If the first few packets sent are padding packets, then no packets are processed until the padding packets end up being dropped when
maxLateis hit.
