webrtc icon indicating copy to clipboard operation
webrtc copied to clipboard

Take direction into account when parsing RTP extensions

Open atoppi opened this issue 3 years ago • 2 comments

Your environment.

  • Version: pion v3.1.0, latest example

What did you do?

I've published the janus video-room client to my local janus master instance

What did you expect?

AV works, no weird output on the janus console

What happened?

AV works BUT janus continuously prints warning about an unknown SSRC

Dropping RTCP packet with unknown SSRC (2596996162)

Wireshark investigations lead to unexpected TWCC reports being sent from the pion client Screenshot from 2021-12-22 12-41-54

I guess those feedbacks are unexpected since janus is sending a SDP answer with recv-only direction.

atoppi avatar Dec 22 '21 11:12 atoppi

even by using a sendonly connection from pion

peerConnection.AddTransceiverFromTrack(vp8Track, webrtc.RtpTransceiverInit{
		Direction: webrtc.RTPTransceiverDirectionSendonly,
	})

the client is still generating dummy twcc feedbacks

atoppi avatar Dec 22 '21 17:12 atoppi

Nice catch! Thanks for reporting @atoppi

I don't think we take direction into account at all when parsing extensions. I will fix that :)

Sean-Der avatar Dec 25 '21 18:12 Sean-Der