parser icon indicating copy to clipboard operation
parser copied to clipboard

support gbk charset

Open spongedu opened this issue 6 years ago • 5 comments

  1. Support charset gbk in parser;
  2. fix description for charsetlatin and charsetbin1 and charsetbin

What problem does this PR solve?

We're using parser to develop some our systems and found that charset gbk is not supported yet in parser, which makes some SQL fail to work. As a MySQL compatible parser, I think we should support gbk as MySQL's parser do, and leave the charset-compatible issues to TiDB layer.

What is changed and how it works?

Add gbk into supported charsets, and add related tests

Check List

Tests

  • Unit test
  • Manual test

spongedu avatar Apr 13 '20 03:04 spongedu

Codecov Report

Merging #808 into master will decrease coverage by 0.08%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #808      +/-   ##
==========================================
- Coverage   78.35%   78.27%   -0.09%     
==========================================
  Files          40       40              
  Lines       14773    14707      -66     
==========================================
- Hits        11576    11512      -64     
- Misses       2509     2515       +6     
+ Partials      688      680       -8     

codecov[bot] avatar Apr 13 '20 03:04 codecov[bot]

Rest LGTM.

Why do we support GBK rather than its superset GB18030?

@kennytm Because we just met gbk in our cases. maybe gb18030 should be supported as well

spongedu avatar Apr 13 '20 06:04 spongedu

PTAL @bb7133 @wjhuang2016

tiancaiamao avatar Apr 20 '20 02:04 tiancaiamao

@wjhuang2016 PTAL :)

spongedu avatar Jun 04 '20 13:06 spongedu

@spongedu: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot avatar Sep 15 '21 20:09 ti-chi-bot